Skip to content

Commit

Permalink
block: remove REQ_NO_TIMEOUT flag
Browse files Browse the repository at this point in the history
This was added for the 'magic' AEN requests in the NVMe driver that never
return.  We now handle them purely inside the driver and don't need this
core hack any more.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Christoph Hellwig authored and axboe committed Dec 22, 2015
1 parent f4800d6 commit bbc758e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 7 deletions.
2 changes: 0 additions & 2 deletions block/blk-mq.c
Expand Up @@ -603,8 +603,6 @@ static void blk_mq_check_expired(struct blk_mq_hw_ctx *hctx,
blk_mq_complete_request(rq, -EIO);
return;
}
if (rq->cmd_flags & REQ_NO_TIMEOUT)
return;

if (time_after_eq(jiffies, rq->deadline)) {
if (!blk_mark_rq_complete(rq))
Expand Down
3 changes: 0 additions & 3 deletions block/blk-timeout.c
Expand Up @@ -197,9 +197,6 @@ void blk_add_timer(struct request *req)
struct request_queue *q = req->q;
unsigned long expiry;

if (req->cmd_flags & REQ_NO_TIMEOUT)
return;

/* blk-mq has its own handler, so we don't need ->rq_timed_out_fn */
if (!q->mq_ops && !q->rq_timed_out_fn)
return;
Expand Down
2 changes: 0 additions & 2 deletions include/linux/blk_types.h
Expand Up @@ -188,7 +188,6 @@ enum rq_flag_bits {
__REQ_PM, /* runtime pm request */
__REQ_HASHED, /* on IO scheduler merge hash */
__REQ_MQ_INFLIGHT, /* track inflight for MQ */
__REQ_NO_TIMEOUT, /* requests may never expire */
__REQ_NR_BITS, /* stops here */
};

Expand Down Expand Up @@ -242,7 +241,6 @@ enum rq_flag_bits {
#define REQ_PM (1ULL << __REQ_PM)
#define REQ_HASHED (1ULL << __REQ_HASHED)
#define REQ_MQ_INFLIGHT (1ULL << __REQ_MQ_INFLIGHT)
#define REQ_NO_TIMEOUT (1ULL << __REQ_NO_TIMEOUT)

typedef unsigned int blk_qc_t;
#define BLK_QC_T_NONE -1U
Expand Down

0 comments on commit bbc758e

Please sign in to comment.