Skip to content

Commit

Permalink
HID: amd_sfh: Rename the float32 variable
Browse files Browse the repository at this point in the history
As float32 is also used in other places as a data type, it is necessary
to rename the float32 variable in order to avoid confusion.

Cc: stable@vger.kernel.org
Tested-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
Signed-off-by: Akshata MukundShetty <akshata.mukundshetty@amd.com>
Link: https://lore.kernel.org/r/20230707065722.9036-2-Basavaraj.Natikar@amd.com
Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
  • Loading branch information
Basavaraj Natikar authored and Benjamin Tissoires committed Jul 10, 2023
1 parent e3ea646 commit c1685a8
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c
Expand Up @@ -132,13 +132,13 @@ static void get_common_inputs(struct common_input_property *common, int report_i
common->event_type = HID_USAGE_SENSOR_EVENT_DATA_UPDATED_ENUM;
}

static int float_to_int(u32 float32)
static int float_to_int(u32 flt32_val)
{
int fraction, shift, mantissa, sign, exp, zeropre;

mantissa = float32 & GENMASK(22, 0);
sign = (float32 & BIT(31)) ? -1 : 1;
exp = (float32 & ~BIT(31)) >> 23;
mantissa = flt32_val & GENMASK(22, 0);
sign = (flt32_val & BIT(31)) ? -1 : 1;
exp = (flt32_val & ~BIT(31)) >> 23;

if (!exp && !mantissa)
return 0;
Expand All @@ -151,10 +151,10 @@ static int float_to_int(u32 float32)
}

shift = 23 - exp;
float32 = BIT(exp) + (mantissa >> shift);
flt32_val = BIT(exp) + (mantissa >> shift);
fraction = mantissa & GENMASK(shift - 1, 0);

return (((fraction * 100) >> shift) >= 50) ? sign * (float32 + 1) : sign * float32;
return (((fraction * 100) >> shift) >= 50) ? sign * (flt32_val + 1) : sign * flt32_val;
}

static u8 get_input_rep(u8 current_index, int sensor_idx, int report_id,
Expand Down

0 comments on commit c1685a8

Please sign in to comment.