Skip to content

Commit c702227

Browse files
HBh25Ymarckleinebudde
authored andcommitted
can: ems_usb: ems_usb_start_xmit(): fix double dev_kfree_skb() in error path
There is no need to call dev_kfree_skb() when usb_submit_urb() fails beacause can_put_echo_skb() deletes the original skb and can_free_echo_skb() deletes the cloned skb. Link: https://lore.kernel.org/all/20220228083639.38183-1-hbh25y@gmail.com Fixes: 702171a ("ems_usb: Added support for EMS CPC-USB/ARM7 CAN/USB interface") Cc: stable@vger.kernel.org Cc: Sebastian Haas <haas@ems-wuensche.com> Signed-off-by: Hangyu Hua <hbh25y@gmail.com> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
1 parent 2e8e79c commit c702227

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

Diff for: drivers/net/can/usb/ems_usb.c

-1
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,6 @@ static netdev_tx_t ems_usb_start_xmit(struct sk_buff *skb, struct net_device *ne
819819

820820
usb_unanchor_urb(urb);
821821
usb_free_coherent(dev->udev, size, buf, urb->transfer_dma);
822-
dev_kfree_skb(skb);
823822

824823
atomic_dec(&dev->active_tx_urbs);
825824

0 commit comments

Comments
 (0)