Skip to content

Commit

Permalink
device-dax: Drop an empty .remove callback
Browse files Browse the repository at this point in the history
The dax core properly handles a dax driver not having a remove callback.
So drop it without changing the effective behaviour.

Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210205222842.34896-5-uwe@kleine-koenig.org
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
  • Loading branch information
ukleinek authored and djbw committed Feb 17, 2021
1 parent e307bf1 commit c80b532
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/dax/device.c
Original file line number Diff line number Diff line change
Expand Up @@ -452,15 +452,9 @@ int dev_dax_probe(struct dev_dax *dev_dax)
}
EXPORT_SYMBOL_GPL(dev_dax_probe);

static int dev_dax_remove(struct dev_dax *dev_dax)
{
/* all probe actions are unwound by devm */
return 0;
}

static struct dax_device_driver device_dax_driver = {
.probe = dev_dax_probe,
.remove = dev_dax_remove,
/* all probe actions are unwound by devm, so .remove isn't necessary */
.match_always = 1,
};

Expand Down

0 comments on commit c80b532

Please sign in to comment.