Skip to content
Permalink
Browse files Browse the repository at this point in the history
net: xilinx_emaclite: Do not print real IOMEM pointer
Printing kernel pointers is discouraged because they might leak kernel
memory layout.  This fixes smatch warning:

drivers/net/ethernet/xilinx/xilinx_emaclite.c:1191 xemaclite_of_probe() warn:
 argument 4 to %08lX specifier is cast from pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
YueHaibing authored and davem330 committed May 21, 2021
1 parent 86fe2f8 commit d0d62ba
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions drivers/net/ethernet/xilinx/xilinx_emaclite.c
Expand Up @@ -1189,9 +1189,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
}

dev_info(dev,
"Xilinx EmacLite at 0x%08lX mapped to 0x%08lX, irq=%d\n",
(unsigned long __force)ndev->mem_start,
(unsigned long __force)lp->base_addr, ndev->irq);
"Xilinx EmacLite at 0x%08lX mapped to 0x%p, irq=%d\n",
(unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq);
return 0;

error:
Expand Down

0 comments on commit d0d62ba

Please sign in to comment.