Skip to content

Commit

Permalink
zram: record accessed second
Browse files Browse the repository at this point in the history
zRam as swap is useful for small memory device.  However, swap means
those pages on zram are mostly cold pages due to VM's LRU algorithm.
Especially, once init data for application are touched for launching,
they tend to be not accessed any more and finally swapped out.  zRAM can
store such cold pages as compressed form but it's pointless to keep in
memory.  Better idea is app developers free them directly rather than
remaining them on heap.

This patch records last access time of each block of zram so that With
upcoming zram memory tracking, it could help userspace developers to
reduce memory footprint.

Link: http://lkml.kernel.org/r/20180416090946.63057-4-minchan@kernel.org
Signed-off-by: Minchan Kim <minchan@kernel.org>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
minchank authored and torvalds committed Jun 8, 2018
1 parent 89e85bc commit d7eac6b
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 0 deletions.
16 changes: 16 additions & 0 deletions drivers/block/zram/zram_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,16 @@ static inline void zram_set_element(struct zram *zram, u32 index,
zram->table[index].element = element;
}

static void zram_accessed(struct zram *zram, u32 index)
{
zram->table[index].ac_time = sched_clock();
}

static void zram_reset_access(struct zram *zram, u32 index)
{
zram->table[index].ac_time = 0;
}

static unsigned long zram_get_element(struct zram *zram, u32 index)
{
return zram->table[index].element;
Expand Down Expand Up @@ -806,6 +816,8 @@ static void zram_free_page(struct zram *zram, size_t index)
{
unsigned long handle;

zram_reset_access(zram, index);

if (zram_test_flag(zram, index, ZRAM_HUGE)) {
zram_clear_flag(zram, index, ZRAM_HUGE);
atomic64_dec(&zram->stats.huge_pages);
Expand Down Expand Up @@ -1177,6 +1189,10 @@ static int zram_bvec_rw(struct zram *zram, struct bio_vec *bvec, u32 index,

generic_end_io_acct(q, rw_acct, &zram->disk->part0, start_time);

zram_slot_lock(zram, index);
zram_accessed(zram, index);
zram_slot_unlock(zram, index);

if (unlikely(ret < 0)) {
if (!is_write)
atomic64_inc(&zram->stats.failed_reads);
Expand Down
1 change: 1 addition & 0 deletions drivers/block/zram/zram_drv.h
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ struct zram_table_entry {
unsigned long element;
};
unsigned long value;
u64 ac_time;
};

struct zram_stats {
Expand Down

0 comments on commit d7eac6b

Please sign in to comment.