Skip to content

Commit

Permalink
ext4: update the cached overhead value in the superblock
Browse files Browse the repository at this point in the history
If we (re-)calculate the file system overhead amount and it's
different from the on-disk s_overhead_clusters value, update the
on-disk version since this can take potentially quite a while on
bigalloc file systems.

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
  • Loading branch information
tytso committed Apr 15, 2022
1 parent 85d825d commit eb70542
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
1 change: 1 addition & 0 deletions fs/ext4/ext4.h
Expand Up @@ -3068,6 +3068,7 @@ int ext4_fileattr_set(struct user_namespace *mnt_userns,
struct dentry *dentry, struct fileattr *fa);
int ext4_fileattr_get(struct dentry *dentry, struct fileattr *fa);
extern void ext4_reset_inode_seed(struct inode *inode);
int ext4_update_overhead(struct super_block *sb);

/* migrate.c */
extern int ext4_ext_migrate(struct inode *);
Expand Down
16 changes: 16 additions & 0 deletions fs/ext4/ioctl.c
Expand Up @@ -1652,3 +1652,19 @@ long ext4_compat_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
return ext4_ioctl(file, cmd, (unsigned long) compat_ptr(arg));
}
#endif

static void set_overhead(struct ext4_super_block *es, const void *arg)
{
es->s_overhead_clusters = cpu_to_le32(*((unsigned long *) arg));
}

int ext4_update_overhead(struct super_block *sb)
{
struct ext4_sb_info *sbi = EXT4_SB(sb);

if (sb_rdonly(sb) || sbi->s_overhead == 0 ||
sbi->s_overhead == le32_to_cpu(sbi->s_es->s_overhead_clusters))
return 0;

return ext4_update_superblocks_fn(sb, set_overhead, &sbi->s_overhead);
}
2 changes: 2 additions & 0 deletions fs/ext4/super.c
Expand Up @@ -5618,6 +5618,8 @@ static int ext4_fill_super(struct super_block *sb, struct fs_context *fc)
ext4_msg(sb, KERN_INFO, "mounted filesystem with%s. "
"Quota mode: %s.", descr, ext4_quota_mode(sb));

/* Update the s_overhead_clusters if necessary */
ext4_update_overhead(sb);
return 0;

free_sbi:
Expand Down

0 comments on commit eb70542

Please sign in to comment.