Skip to content

Commit

Permalink
iio:addac:ad74413r: Fix uninitialized ret in a path that won't be hit.
Browse files Browse the repository at this point in the history
I don't believe it's possible to hit this, because we drop
out of __iio_update_buffers() earlier in the event of an empty
list.  However, that is not visible to the compiler so lets
return an error if we do hit the loop with an empty bitmask.

Fixes: 5d97d9e ("iio: addac: ad74413r: fix off by one in ad74413r_parse_channel_config()")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Cosmin Tanislav <cosmin.tanislav@analog.com>
Link: https://lore.kernel.org/r/20211220164726.3136307-1-jic23@kernel.org
  • Loading branch information
jic23 committed Dec 21, 2021
1 parent bfcacdd commit f4a73a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iio/addac/ad74413r.c
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ static int ad74413r_update_scan_mode(struct iio_dev *indio_dev,
u8 *rx_buf = &st->adc_samples_buf.rx_buf[-1 * AD74413R_FRAME_SIZE];
u8 *tx_buf = st->adc_samples_tx_buf;
unsigned int channel;
int ret;
int ret = -EINVAL;

mutex_lock(&st->lock);

Expand Down

0 comments on commit f4a73a9

Please sign in to comment.