Skip to content
Browse files

aacraid: missing capable() check in compat ioctl

In commit d496f94 ('[SCSI] aacraid: fix security weakness') we
added a check on CAP_SYS_RAWIO to the ioctl.  The compat ioctls need the
check as well.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information...
1 parent c2c65cd commit f856567b930dfcdbc3323261bf77240ccdde01f5 Dan Carpenter committed with Oct 29, 2013
Showing with 2 additions and 0 deletions.
  1. +2 −0 drivers/scsi/aacraid/linit.c
View
2 drivers/scsi/aacraid/linit.c
@@ -771,6 +771,8 @@ static long aac_compat_do_ioctl(struct aac_dev *dev, unsigned cmd, unsigned long
static int aac_compat_ioctl(struct scsi_device *sdev, int cmd, void __user *arg)
{
struct aac_dev *dev = (struct aac_dev *)sdev->host->hostdata;
+ if (!capable(CAP_SYS_RAWIO))
+ return -EPERM;
return aac_compat_do_ioctl(dev, cmd, (unsigned long)arg);
}

0 comments on commit f856567

Please sign in to comment.
Something went wrong with that request. Please try again.