Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deref to take the underlying bbqueue addr for tracing #10

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

jamesmunns
Copy link
Contributor

Have tracing report the address of the underlying storage (rather than the address of the Arc itself) so that it is easier to see related comms in traces.

Before:

  10.670354843s TRACE Kernel:Driver B:BBQueue::read_grant{queue=0x7f7758014548 side=BSide}: kernel::bbq: awaiting bbqueue read grant
  11.168783665s  WARN Kernel:Driver A: melpomene: Driver A: Reading...
  11.170023311s TRACE Kernel:Driver A:BBQueue::read_grant{queue=0x7f77580139a0 side=ASide}: kernel::bbq: Got bbqueue read grant size=4
  11.170525095s  WARN Kernel:Driver A: melpomene: Driver A: Got data buf=[245, 245, 245, 245]

After

  2.079232514s TRACE Kernel:Driver A:BBQueue::send_grant_exact{size=8 queue=0x7f08a8014700 side=ASide}: kernel::bbq: Got bbqueue exact write grant
  2.079650683s  INFO Kernel:Driver A: melpomene: Driver A: Sleeping...
  2.080172776s  WARN Kernel:Driver B: melpomene: Driver B: Reading...
  2.080742401s TRACE Kernel:Driver B:BBQueue::read_grant{queue=0x7f08a8014700 side=BSide}: kernel::bbq: Got bbqueue read grant size=8
  2.081164016s  WARN Kernel:Driver B: melpomene: Driver B: Got data buf=[1, 1, 1, 1, 1, 1, 1, 1]
  2.081413875s  INFO Kernel:Driver B: melpomene: Driver B: Writing...

@jamesmunns jamesmunns requested a review from hawkw July 10, 2022 00:21
@jamesmunns jamesmunns merged commit ac024ba into main Jul 11, 2022
@hawkw
Copy link
Contributor

hawkw commented Jul 11, 2022

Ohh, I see...I thought those were the same.

@hawkw
Copy link
Contributor

hawkw commented Jul 11, 2022

I think the HeapArc fmt::Pointer impl accidentally prints the address of the &self receiver when I intended it to point the actual pointed address of the arc'd storage. We should fix that upstream too...

@jamesmunns jamesmunns deleted the james/bbq-tracing branch July 17, 2022 00:01
jamesmunns added a commit that referenced this pull request Jun 4, 2023
This PR adds a couple of helpers that allow for writing rustc-style "ui tests", where you can specify a chunk of
forth code as a runnable test. This replaces quite a number of ad-hoc structures to achieve this in the current
unit testing frameworks.

Options are provided for testing blocking, async, or both VM configurations. 

---

* Initial ui tester
* Port the standalone ui-test capability to a testutil
* Docs and more methods
* Ready to review
* Removed standalone ui-test project
* Ported all tests over to runtest infra
* Added async runtest infra
* Remove temp hack
* Switch ordering per suggestion
@jamesmunns jamesmunns added the area: tools & build Related to host developer tools, including tracing, Crowtty and build processes label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tools & build Related to host developer tools, including tracing, Crowtty and build processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants