-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make spawnulator a service #106
Conversation
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There is a slight footgun, in that it is possible to try to spawn forth tasks without Open to suggestions on how to fix this, including maybe lazily/racily spawning the spawnulator instead of doing the normal "wait until the server appears" behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always be spawnulating
I ran into this again while developing #110, which means I should definitely fix it. |
maybe we could have an atomic flag that gets set when the spawnulator is spawnulated? and check that every time we spawn a forth task. minor overhead but it's probably fine. |
This PR moves the spawnulator into a kernel service, allowing for potentially
"non-hierarchical" forth instances (e.g. a tid0 gui and tid1 sermux instance) to
use the same spawnulator.