feat(allwinner-d1): panic handling improvements #116
Conversation
This commit changes crowtty to attempt to decode any output that isn't in a SerMux frame as text. This lets us get panic output and other stuff, like `xfel`'s bootloader output. 
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| fn die() -> ! { | ||
| loop { | ||
| core::sync::atomic::fence(Ordering::SeqCst); |
There was a problem hiding this comment.
Not a huge deal, but you could wfi loop here instead to not heat the CPU (it'll probably just never wake)
| } | ||
|
|
||
| // TODO(eliza): abort any in-flight DMAs. | ||
|
|
||
| // Ugly but works | ||
| let mut uart: Uart = unsafe { core::mem::transmute(()) }; | ||
|
|
||
| write!(&mut uart, "\r\n").ok(); |
There was a problem hiding this comment.
You might want a null BEFORE as well, to force the end of the previous frame.
Additionally, you also probably want to either busy wait until the DMAC transfer is complete, or hard-stop any DMAC transfers that are ongoing, before manually driving the panic, otherwise I dunno how pushing bytes into the fifo while the DMAC is also doing it would go.
There was a problem hiding this comment.
yeah, i left a TODO about killing DMAC transfers. i intend to do that in a follow-up but will have to read the data sheet first.
jamesmunns
added
platform: D1
This branch contains two commits:
feat(allwinner-d1): disable IRQs in panic
This commit changes the panic handler for the D1 to disable
interrupts, and adds a flag for tracking double panics. If we panic
inside the panic handler, we now just die immediately instead of
trying to print something.
feat(crowtty): try to decode loose utf8
This commit changes crowtty to attempt to decode any output that isn't
in a SerMux frame as UTF-8 text. This lets us get panic output without
having to do fancy COBS encoding in the panic handler. It also lets us
see other stuff, like
xfel's bootloader output.For example:
