-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(beepy): add a mediocre i2c_puppet
driver
#155
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunns
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits, overall looks good! Looking forward to playing with it :D
12 tasks
jamesmunns
added
platform: D1
Specific to the Allwinner D1 hardware platform
area: drivers
Related to driver implementation for hardware devices.
labels
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: drivers
Related to driver implementation for hardware devices.
platform: D1
Specific to the Allwinner D1 hardware platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #154.
This branch adds a simple driver for the
i2c_puppet
firmware on theBeepy RP2040. It allows controlling the status LED and reading
keypresses.
Key input can be read by sending a message to the driver service to
subscribe to keypresses. The driver task tracks a list of subscriptions
(channels) and broadcasts each keystroke to all subscribers. In
addition, the status LED and backlight can be controlled by sending
messages to the driver task.
The keyboard driver is in a new
mnemos-beepy
crate inplatforms
thatcontains drivers for the Beepy hardware that are implemented using
cross-platform driver service definitions. Right now, this is just the
i2c_puppet
driver, which is implemented against the kernel'scross-platform
I2cService
interface. However, in the future, if we canwrite a generic driver interface for SPI in the kernel crate, we could
move the SHARP display driver into
mnemos-beepy
as well.Currently, the way the keyboard is implemented is pretty bad: we poll
the keyboard for new keystrokes periodically, as long as at least one
task is subscribed. This is wildly inefficient and we should instead
have the
i2c_puppet
send us an interrupt when new keystrokes areready. However, this will require code for configuring the D1 to
actually generate interrupts on GPIO pins, which we haven't written yet.
I'll add this in a later branch and rewrite the keyboard driver to use
that.
Keyboard input isn't actually wired up to anything yet --- we just run a
task that logs all keypresses. A subsequent branch will actually make
the forth shell handle keyboard input.