refac(melpomene): run TCP serial driver on Tokio #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
force-pushed
the
eliza/tokio-serial
branch
from
f4e0652
to
7f23123
Compare
|
Something is causing the TCP task to be polled constantly, I sent you a message in matrix with a screencap video |
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Yup, just fixed that --- that's my fault for copying the blocking code too religiously. 6402f28 fixes that. I also figured out how to use |
|
Awesome, thanks! Can confirm it looks good to me. Also, if you want to break this into two tasks, that's totally fine with me. The BidiHandles have a |
jamesmunns
pushed a commit
that referenced
this pull request
Jun 4, 2023
The `Forth` and `AsyncForth` types are `!Send`. This makes them difficult to use with the latest `maitake`, which requires futures be `Send` in order to be spawned as a task. These types are `!Send` because they contain raw pointers to the buffer regions provided when the VM is constructed. I think they can be made `Send` (and `Sync`), based on the rationale that the unsafety is in the invariants of calling `Forth::new` --- if the VM is sent across a thread boundary, the buffer regions provided to `Forth::new` must travel with it. Thus, `Forth::new` should still be unsafe, but the VM *can* be `Send` if `Forth::new`'s invariants are upheld. Alternatively, we could solve this by wrapping `Forth` in a type which has ownership over the buffers plus a deallocation callback for those buffers, instead. This would be similar to `LBForth` but without the use of `Box`. That type could always be `Send` and `Sync`, without the caveats I mentioned above.
jamesmunns
added
platform: melpomene
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch rewrites the TCP serial port simulated driver to run in
Melpomene's Tokio runtime, rather than spawning its own thread. This
should make Melpomene a bit more efficient, since the runtime thread can
run other simulated drivers while the serial driver task is waiting for
IO, instead of doing a bunch of little sleeps.
I think this shouldn't result in any real behavioral change, although
I haven't tested it super extensively. If I open
crowttyand then killit after a while, Melpomene still sees the TCP stream
disconnection...but I wasn't sure how I was supposed to actually start
the simulated serial port after launching
crowtty? Any suggestions onfurther testing would be appreciated! :)