feat(melpo+config): Initial "platform configuration" support, starting with Melpo #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmunns
changed the title
jamesmunns
commented
Aug 2, 2023
hawkw
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
overall, this looks good!
one question is that it seems like there isn't currently a way to declare defaults when the config is declared, so the config file has to specify everything. is this desirable, or should we allow leaving a field blank to let it be defaulted?
hawkw
reviewed
Aug 2, 2023
jamesmunns
added
the
platform: melpomene
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the initial work towards implementing #199.
This introduces a
configcrate, which provides tools for platforms to have compile time defined configuration as a toml file.This PR only implements these changes for
melpomene, as adding support to hardware platforms may require more invasive crate re-orgs.