chore: make VS Code rust-analyzer run just clippy
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the VS Code settings so that rust-analyzer will run the `just clippy` command instead of `cargo clippy` when running checks. Because the `just clippy` command will check all crates in the workspace, not just the default members, this means VS Code users will get clippy warnings/errors for *all* crates in the workspace, even the ones that can't be checked as part of a global `cargo clippy --workspace` command. This should substantially improve the dev experience for VS Code users. This change required adding an optional trailing `ARGS` argument to the `just clippy` recipe so that additional args can be passed to Clippy (in this case `--message-format=json --quiet --all-targets`, to mimic the way `rust-analyzer` normally invokes `cargo check`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the VS Code settings so that rust-analyzer will run the
just clippycommand instead ofcargo clippywhen running checks. Because thejust clippycommand will check all crates in the workspace, not just the default members, this means VS Code users will get clippy warnings/errors for all crates in the workspace, even the ones that can't be checked as part of a globalcargo clippy --workspacecommand. This should substantially improve the dev experience for VS Code users.This change required adding an optional trailing
ARGSargument to thejust clippyrecipe so that additional args can be passed to Clippy (in this case--message-format=json --quiet --all-targets, to mimic the wayrust-analyzernormally invokescargo check).