Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pomelo workspace checks unfucking #263

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Aug 30, 2023

This branch makes two changes:

  1. Turns out I had forgotten to add pomelo to the Just commands that run a
    check for all crates, like just check, just clippy, and just docs. So,
    it was never actually being checked, on CI or in VS Code (MY BAD LMAO).
    Therefore, this branch adds it to those recipes so it actually gets checked.

  2. Once we actually include pomelo in just check, it turns out that the
    build is fucked, because Cargo doesn't realize what target to build pomelo
    for. Thus, I've also added a missing forced-target="wasm32-unknown-unknown
    to pomelo's Cargo.toml, which should unfuck it.

  3. Also I fixed an "unnecessary mut" warning, because now that we're actually
    linting pomelo on CI, it turns out that it, uh, has lints. Whoops.

Turns out I had forgotten to add `pomelo` to the Just commands that run
a check for all crates, so it was just never being checked. MY BAD LMAO.
@hawkw
Copy link
Contributor Author

hawkw commented Aug 30, 2023

well, now CI fails for an actually legitimate reason, because pomelo has one warning in it: https://github.com/tosc-rs/mnemos/actions/runs/6018848174/job/16327759771?pr=263#step:8:1186

@hawkw hawkw enabled auto-merge (squash) August 30, 2023 00:30
@hawkw hawkw merged commit 45f1167 into main Aug 30, 2023
7 checks passed
@hawkw hawkw deleted the eliza/pomelo-build-unfucking branch August 30, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants