refac(D1): move spin delay from ccu to clint
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch addresses a minor TODO in the `ccu` module, by moving the spin delay function from the `ccu` module into a function on the `Clint` type. Additionally, I've removed the `&self` receiver from `Clint::get_mtime`, since we don't actually use the `&self`. This lets us change `get_mtime` to a free function, and therefore remove the `unsafe` calls to `Clint::summon()` in a few places, so we can get rid of a few unneeded `unsafe` blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch addresses a minor TODO in the
ccumodule, by moving the spin delay function from theccumodule into a function on theClinttype. Additionally, I've removed the&selfreceiver fromClint::get_mtime, since we don't actually use the&self. This lets us changeget_mtimeto a free function, and therefore remove theunsafecalls toClint::summon()in a few places, so we can get rid of a few unneededunsafeblocks.