Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguous cli arguments #33

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix ambiguous cli arguments #33

merged 1 commit into from
Jul 25, 2022

Conversation

jamesmunns
Copy link
Contributor

Prior to this, both the console addr and modality addr were getting the same default constructor, meaning both the console and modality were trying to bind/connect to port 6699, which seems like a weird and fun behavior of flatten. I've made the names more verbose now to avoid the issue.

@jamesmunns jamesmunns requested a review from hawkw July 25, 2022 15:07
@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for merry-scone-cc7a60 ready!

Name Link
🔨 Latest commit 07e36de
🔍 Latest deploy log https://app.netlify.com/sites/merry-scone-cc7a60/deploys/62deb1b184c3520008246006
😎 Deploy Preview https://deploy-preview-33--merry-scone-cc7a60.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jamesmunns jamesmunns merged commit ea31880 into main Jul 25, 2022
@jamesmunns jamesmunns deleted the james/fix-cli-args branch July 25, 2022 15:14
@jamesmunns jamesmunns added the platform: melpomene Specific to the Melpomene simulator platform label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: melpomene Specific to the Melpomene simulator platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant