Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate console loopback demo #42

Merged
merged 9 commits into from
May 29, 2023
Merged

Integrate console loopback demo #42

merged 9 commits into from
May 29, 2023

Conversation

jamesmunns
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented May 27, 2023

Deploy Preview for merry-scone-cc7a60 ready!

Name Link
🔨 Latest commit f5b6977
🔍 Latest deploy log https://app.netlify.com/sites/merry-scone-cc7a60/deploys/6474fadd94e3f800088a5ba5
😎 Deploy Preview https://deploy-preview-42--merry-scone-cc7a60.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hawkw hawkw self-requested a review May 27, 2023 16:28
@jamesmunns
Copy link
Contributor Author

jamesmunns commented May 27, 2023

Can I embed youtube stuff?

Edit: Nope. Here's a link instead.

@jamesmunns jamesmunns changed the title WIP: integrate console loopback demo Integrate console loopback demo May 29, 2023
source/melpomene/src/main.rs Show resolved Hide resolved
source/melpomene/src/main.rs Show resolved Hide resolved
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great overall! i had a few minor style suggestions

source/melpomene/src/sim_drivers/emb_display.rs Outdated Show resolved Hide resolved
source/melpomene/src/main.rs Outdated Show resolved Hide resolved
source/melpomene/src/main.rs Show resolved Hide resolved
source/melpomene/src/main.rs Outdated Show resolved Hide resolved
@jamesmunns jamesmunns merged commit 01bd9f7 into main May 29, 2023
8 checks passed
@jamesmunns jamesmunns deleted the loopback branch May 29, 2023 19:48
hawkw pushed a commit that referenced this pull request May 31, 2023
This commit adds an initial integration of the Forth VM from `forth3`
into mnemOS, building on the console implementation added in #42 to
display the user's input into the forth VM and the forth VM's output.
The forth VM runs in a separate task, with its "standard in" and
"standard out" streams represented by a bidirectional BBQueue.

Code for running the Forth VM task is in the `kernel` crate, but the
current console implementation is Melpomene-specific. This should be
addressed eventually. Currently, only a single Forth task is spawned,
but subsequent changes will allow a Forth "PID 0" task to spawn child
tasks.

Co-authored-by: James Munns <james@onevariable.com>
Signed-off-by: Eliza Weisman <eliza@elizas-website>
@jamesmunns jamesmunns added area: kernel Related to the cross-platform kernel area: drivers Related to driver implementation for hardware devices. labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: drivers Related to driver implementation for hardware devices. area: kernel Related to the cross-platform kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants