-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate console loopback demo #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also port over the `teletype` b/w example
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Can I embed youtube stuff? Edit: Nope. Here's a link instead. |
jamesmunns
changed the title
WIP: integrate console loopback demo
Integrate console loopback demo
May 29, 2023
hawkw
reviewed
May 29, 2023
hawkw
approved these changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great overall! i had a few minor style suggestions
hawkw
pushed a commit
that referenced
this pull request
May 31, 2023
This commit adds an initial integration of the Forth VM from `forth3` into mnemOS, building on the console implementation added in #42 to display the user's input into the forth VM and the forth VM's output. The forth VM runs in a separate task, with its "standard in" and "standard out" streams represented by a bidirectional BBQueue. Code for running the Forth VM task is in the `kernel` crate, but the current console implementation is Melpomene-specific. This should be addressed eventually. Currently, only a single Forth task is spawned, but subsequent changes will allow a Forth "PID 0" task to spawn child tasks. Co-authored-by: James Munns <james@onevariable.com> Signed-off-by: Eliza Weisman <eliza@elizas-website>
jamesmunns
added
area: kernel
Related to the cross-platform kernel
area: drivers
Related to driver implementation for hardware devices.
labels
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: drivers
Related to driver implementation for hardware devices.
area: kernel
Related to the cross-platform kernel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.