Restore missing commit from mnemos-alloc repo. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was missed when I merged from the upstream repo: commit 3b1b16d7c04f312a27befb1f1f7691f5f63cfb47 Author: Eliza Weisman <eliza@buoyant.io> Date: Thu Jun 1 08:15:12 2023 -0700 add missing `Send` impl for `AHeap` (#9) Currently, any Future that awaits one of the AHeap allocate, allocate_arc, allocate_array_with, or allocate_fixed_vec methods is !Send. This is because these methods return a Future which contains a &self receiver, and the AHeap type itself is !Send. This is sad and not very great. This branch adds a missing Send impl to AHeap. This should be safe for the same reason that the existing unsafe impl Sync for AHeap is safe. * add test asserting heap futures are Send * add missing Send impl for AHeap
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit was missed when I merged from the upstream repo:
tosc-rs/mnemos-alloc#9
commit 3b1b16d7c04f312a27befb1f1f7691f5f63cfb47
Author: Eliza Weisman eliza@buoyant.io
Date: Thu Jun 1 08:15:12 2023 -0700
add missing
Sendimpl forAHeap(#9)Currently, any Future that awaits one of the AHeap allocate,
allocate_arc, allocate_array_with, or allocate_fixed_vec methods
is !Send. This is because these methods return a Future which
contains a &self receiver, and the AHeap type itself is !Send.
This is sad and not very great.
This branch adds a missing Send impl to AHeap. This should be safe
for the same reason that the existing unsafe impl Sync for AHeap is
safe.