chore: run tests on CI #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, CI just runs `cargo check` and `cargo fmt`, and never actually runs host tests. Some crates in the repo, such as `forth3`, contain tests that should be run on the host. This branch adds a `cargo test` job to the CI workflow. Closes #58
✅ Deploy Preview for merry-scone-cc7a60 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Looks like the build is failing because e-g-sim requires Would it make sense to restore the forth3 miri tests here too? |
yeah, it would! |
currently, the kernel crate doesn't use any custom test harnesses, so this is not necessary. since the kernel is intended to be cross platform, it's unclear to me whether we will ever want to write platform-specific tests in the kernel crate, or if we'll just run host tests there and run platform-specific tests in platform crates. in any case, `harness = "false"` was making `cargo test` runs in the whole workspace fail, so i've removed it. alternatively, we could change CI to only test specific packages that have host tests, but it's nice for `cargo test`/`cargo nextest run` to Just Work. @jamesmunns, does that seem reasonable to you?
jamesmunns
added
the
area: tools & build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CI just runs
cargo checkandcargo fmt, and never actually runs host tests. Some crates in the repo, such asforth3, contain tests that should be run on the host.This branch adds a
cargo testjob to the CI workflow.Closes #58