Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add D1 platform (2023 edition) #69

Merged
merged 18 commits into from
Jun 13, 2023
Merged

Add D1 platform (2023 edition) #69

merged 18 commits into from
Jun 13, 2023

Conversation

jamesmunns
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 11, 2023

Deploy Preview for merry-scone-cc7a60 ready!

Name Link
🔨 Latest commit 5399009
🔍 Latest deploy log https://app.netlify.com/sites/merry-scone-cc7a60/deploys/64888e136499100008baeb84
😎 Deploy Preview https://deploy-preview-69--merry-scone-cc7a60.netlify.app/doc/src/drivers/plic.rs
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hawkw
Copy link
Contributor

hawkw commented Jun 11, 2023

nice

Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you love to see it!!

platforms/allwinner-d1/boards/lichee-rv/src/main.rs Outdated Show resolved Hide resolved
platforms/allwinner-d1/drivers/src/lib.rs Outdated Show resolved Hide resolved
@jamesmunns jamesmunns changed the title WIP: Add D1 platform (2023 edition) Add D1 platform (2023 edition) Jun 12, 2023
@jamesmunns jamesmunns marked this pull request as ready for review June 12, 2023 15:03
Copy link
Contributor

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but this is awesome!

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
platforms/allwinner-d1/drivers/src/plic.rs Show resolved Hide resolved
platforms/allwinner-d1/drivers/src/plic.rs Show resolved Hide resolved
platforms/allwinner-d1/drivers/src/plic.rs Outdated Show resolved Hide resolved
tools/crowtty/src/main.rs Show resolved Hide resolved
@jamesmunns
Copy link
Contributor Author

@hawkw breaking this out as a longer response:

is this Lichee-RV specific, or is this UART built into the D1 SOC?

So, some of these things COULD be portable to any user of the D1, however there's a very fuzzy line today. I haven't really tackled any of the "portability challenges", like handling different configs, or pin mapping, or what DMA channel to use, or even how to handle interrupts.

These absolutely should live in the allwinner-d1/drivers crate, but the current state of the code isn't suitable for that yet. I could put it there, but it's all very hardcoded for just this one board, so far.

@hawkw
Copy link
Contributor

hawkw commented Jun 13, 2023

@hawkw breaking this out as a longer response:

is this Lichee-RV specific, or is this UART built into the D1 SOC?

So, some of these things COULD be portable to any user of the D1, however there's a very fuzzy line today. I haven't really tackled any of the "portability challenges", like handling different configs, or pin mapping, or what DMA channel to use, or even how to handle interrupts.

These absolutely should live in the allwinner-d1/drivers crate, but the current state of the code isn't suitable for that yet. I could put it there, but it's all very hardcoded for just this one board, so far.

Great, thanks — I was mostly just curious about whether this could ever move to the allwinner-d1 crate. We definitely don't need to do that in this PR if it's not ready yet.

@jamesmunns jamesmunns merged commit 11ca8a7 into main Jun 13, 2023
11 checks passed
@jamesmunns jamesmunns deleted the james/d1-platform branch June 13, 2023 15:50
@jamesmunns jamesmunns added platform: D1 Specific to the Allwinner D1 hardware platform area: drivers Related to driver implementation for hardware devices. labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: drivers Related to driver implementation for hardware devices. platform: D1 Specific to the Allwinner D1 hardware platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants