Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel: add helper fn for oneshot driver requests #76

Merged
merged 10 commits into from
Jun 21, 2023

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 20, 2023

Depends on #75

This commit adds a KHandle::request_oneshot helper function that bundles together code for sending a request with a reusable oneshot sender as the message, and awaiting the response. This pattern occurred a few times in service client implementations, so I thought it might be nice to have a helper method for it.

We can add similar methods for other types of requests later.

jamesmunns and others added 8 commits June 20, 2023 01:01
This commit adds a `KHandle::request_oneshot` helper function that
bundles together code for sending a request with a reusable oneshot
sender as the message, and awaiting the response. This pattern occurred
a few times in service client implementations, so I thought it might be
nice to have a helper method for it.

We can add similar methods for other types of requests later.
Base automatically changed from james/service-service to main June 21, 2023 00:34
@netlify
Copy link

netlify bot commented Jun 21, 2023

Deploy Preview for merry-scone-cc7a60 ready!

Name Link
🔨 Latest commit 6fb212e
🔍 Latest deploy log https://app.netlify.com/sites/merry-scone-cc7a60/deploys/64924810011f590008fc60bd
😎 Deploy Preview https://deploy-preview-76--merry-scone-cc7a60.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you :)

@jamesmunns jamesmunns merged commit 2aa9ba8 into main Jun 21, 2023
11 checks passed
@jamesmunns jamesmunns deleted the eliza/svc-patterns branch June 21, 2023 00:51
@jamesmunns jamesmunns added the area: kernel Related to the cross-platform kernel label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: kernel Related to the cross-platform kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants