Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crowtty): logs indicate if target is TCP/UART #91

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

hawkw
Copy link
Contributor

@hawkw hawkw commented Jun 24, 2023

This commit adds a small additional indicate to crowtty's logs to show whether the target connection is over TCP serial or over the UART.

This commit adds a small additional indicate to `crowtty`'s logs to show
whether the target connection is over TCP serial or over the UART.
@netlify
Copy link

netlify bot commented Jun 24, 2023

Deploy Preview for merry-scone-cc7a60 ready!

Name Link
🔨 Latest commit db8b6ac
🔍 Latest deploy log https://app.netlify.com/sites/merry-scone-cc7a60/deploys/649736892eadeb0008b7bf95
😎 Deploy Preview https://deploy-preview-91--merry-scone-cc7a60.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@hawkw hawkw requested a review from jamesmunns June 24, 2023 18:31
Copy link
Contributor

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! We might want CLI or config control eventually, but not today is okay.

@jamesmunns jamesmunns merged commit 6d6a317 into main Jun 24, 2023
11 checks passed
@jamesmunns jamesmunns deleted the eliza/crowtty-indicate branch June 24, 2023 19:18
@jamesmunns jamesmunns added the area: tools & build Related to host developer tools, including tracing, Crowtty and build processes label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tools & build Related to host developer tools, including tracing, Crowtty and build processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants