Skip to content

Commit

Permalink
Fixed failure with checkbox
Browse files Browse the repository at this point in the history
  • Loading branch information
Greg Jurman committed Mar 12, 2012
1 parent fdbd18b commit 042fa5d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions tests/test_widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,20 +18,20 @@
class TestInputField(WidgetTest):
widget = InputField
attrs = {'type':'foo', 'css_class':'something'}
params = {'value':6}
expected = '<input type="foo" class="something" value="6"/>'
params = {'value':7}
expected = '<input type="foo" class="something" value="7"/>'

class TestTextField(WidgetTest):
widget = TextField
attrs = {'css_class':'something', 'size':'60', 'placeholder': "Search..."}
params = {'value':6}
attrs = {'css_class':'something', 'size':'60'}
params = {'value':6, 'placeholder': "Search..."}
expected = '<input type="text" class="something" placeholder="Search..." value="6" size="60"/>'

class TestTextArea(WidgetTest):
widget = TextArea
attrs = {'css_class':'something', 'rows':6, 'cols':10}
params = {'value':'6'}
expected = '<textarea class="something" rows="6" cols="10">6</textarea>'
params = {'value':'5'}
expected = '<textarea class="something" rows="6" cols="10">5</textarea>'

class TestCheckbox(WidgetTest):
widget = CheckBox
Expand All @@ -40,8 +40,8 @@ class TestCheckbox(WidgetTest):
expected = '<input checked="checked" value="True" type="checkbox" class="something"/>'

def test_value_false(self):
params = {'value':False}
expected = '<input value="False" type="checkbox" class="something">'
params = {'value': False}
expected = '<input type="checkbox" class="something">'
for engine in self._get_all_possible_engines():
yield self._check_rendering_vs_expected, engine, self.attrs, params, expected

Expand Down
2 changes: 1 addition & 1 deletion tw2/forms/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ class CheckBox(InputField):
def prepare(self):
super(CheckBox, self).prepare()
self.safe_modify('attrs')
self.attrs['checked'] = self.value and 'checked' or None
self.attrs['checked'] = 'checked' if self.value in [True, 'checked'] else None
self.value = None


Expand Down

0 comments on commit 042fa5d

Please sign in to comment.