localization of the site to Brazilian Portuguese #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I'm now done adding everything needed for the translation. @gaugsouza, feel free to review it before we send the PR. |
|
Awesome! I'll merge it so it will soon appear on the production environment! |
|
Thanks, @JustinBack ! It appears the deploy has already taken effect, considering that Brazilian Portuguese now appears as an option. But for some reason the translated strings are not loading and we get English instead.
What could be wrong? I took the |
|
I believe the issues lies in postgres only storing data in lowercase where as pt_BR contains uppercase letters and not finding it (can be reproduced on mexican spanish), I'll deploy a fix |
|
The issue has been fixed, thanks for reporting! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft PR so we can start translating the site to Brazilian Portuguese. When all is done and reviewed, we shall submit the pull request.