Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a CLI flag to set the cluster name #23

Merged
merged 2 commits into from Oct 21, 2018
Merged

Conversation

fhaynes
Copy link
Member

@fhaynes fhaynes commented Oct 20, 2018

No description provided.

@fhaynes fhaynes requested a review from hntd187 October 20, 2018 20:44
@fhaynes fhaynes added this to the 0.2.0 milestone Oct 20, 2018
@fhaynes
Copy link
Member Author

fhaynes commented Oct 20, 2018

Resolves #21

@codecov
Copy link

codecov bot commented Oct 20, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files          13       13           
  Lines         836      836           
=======================================
  Hits          754      754           
  Misses         82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0342e08...8508c89. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 20, 2018

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.9%

Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines: 889
Relevant Lines: 1000

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 96

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at ?%

Totals Coverage Status
Change from base Build 94: 0.0%
Covered Lines:
Relevant Lines: 0

💛 - Coveralls

Fixes the short arg for cluster name
@fhaynes fhaynes merged commit 99e1917 into master Oct 21, 2018
@hntd187 hntd187 deleted the 21-add-cluster-name-cli branch October 21, 2018 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants