Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple images for adding new cations #53

Open
SilentD1 opened this issue Mar 8, 2023 · 7 comments · Fixed by #54
Open

Select multiple images for adding new cations #53

SilentD1 opened this issue Mar 8, 2023 · 7 comments · Fixed by #54

Comments

@SilentD1
Copy link

SilentD1 commented Mar 8, 2023

I really would like to be able to select more than one image from the main window, and then hit "apply changes to selected imageS" when I have many with the same caption. I am currently going through large datasets and selecting each image to edit is not fun. Yes Im using this to create captions. NOT just to edit

@toshiaki1729
Copy link
Owner

toshiaki1729 commented Mar 8, 2023

Sorry, please forget about my previous comment (deleted).
I will implement the feature.

@toshiaki1729 toshiaki1729 linked a pull request Mar 8, 2023 that will close this issue
@SilentD1
Copy link
Author

SilentD1 commented Mar 8, 2023

Thanks for trying, but I dont think you understood. Now you changed it to all displayed, but I still cant select the specific images I want. Say I have 1000 images. They dont have any tags yet. I want to select 20, type a caption and apply that caption to those 20 photos. then I move on to the next batch.

Having to select each photo to become displayed, and first THEN I can apply a caption to them all is even more time consuming. The "filter by selected" tab, adds an extra unnecessary step that can be avoided. Just let us select any photo in the main window, and do with them what we want. MULTI SELECT.

If that is not possible I suggest another option:

You already ALMOST have it.

The "Filter by selection" tab, has a button "add selection" You can use the ENTER key on it.
This allows for quick arrow keys selection for each image. So thats good. But why do the extra step of adding each image to selection before I can edit their tag.

If you allow "apply changes to selected image" to be triggered by ENTER key. I could use arrow keys to select each image very fast and skip the filter by selection tab entirely.

That one feature would save me 80% time "arrow key, enter, arrow key enter, arrow key, enter" done

there are just too many mouse clicks to make it a powerful tool that it could be. More keyboard shortcuts would greatly improve its usability

@toshiaki1729 toshiaki1729 reopened this Mar 9, 2023
@toshiaki1729 toshiaki1729 added wontfix This will not be worked on and removed wontfix This will not be worked on labels Mar 9, 2023
@toshiaki1729
Copy link
Owner

toshiaki1729 commented Mar 9, 2023

I totally agree with you. It is redundant and annoying to select each by each.
But this extension is working on gradio, which is a simple tool to make simple GUI for ML. In other words, it is not designed to manage files as this extension do (nor designed for apps with many many interfaces like webUI, actually).
To manage files as explorer.exe or modern cloud apps do, it is needed to implement GUI with javascript from scratch (like openOutpaint extension).
However, unfortunately, I have no experience or knowledge to make GUI working on web browser.
I reopen this issue as a reminder, but please note that I have no plan to actively add the feature you expected.

@toshiaki1729
Copy link
Owner

toshiaki1729 commented Mar 9, 2023

If you allow "apply changes to selected image" to be triggered by ENTER key. I could use arrow keys to select each image very fast and skip the filter by selection tab entirely.

This could be good for solving this issue.
But, for the future, I will try to implement this as custom keybord shortcut feature.

@SilentD1
Copy link
Author

SilentD1 commented Mar 9, 2023

avesome, that would be greatly appreciated. I just spent 5 hours editing captions. and unfortunately there is no better way to manually create captions to my knowledge. Your extension is quite good. I especially like the negative filter options that hide images that I already tagged. great option.

@a-l-e-x-d-s-9
Copy link

It seems like the most natural workflow, to select multiple images from the preview and apply certain tags to them all at once.
Going one by one is a Sisyphean work even with a small number of images.

@noisefloordev
Copy link

I ran into this too. For example, if you have an image set of a character with two outfits, and you want to tag each outfit correctly for training. You want it to say "Add the tag?" for each image and just click "Yes" "No" "Yes" "Yes" "No".

This is the best way I've found. This was discussed above, but it's bured in conversation, here are steps in case it helps anyone else:

  • Select "Filter by selection"
  • Click the first image in the grid
  • If the image should have the tag, press Enter to add it to the list.
  • Press Right to move to the next image.
  • Repeat until you reach the end

When you're at the end, click "Apply selection filter". Now you can use Batch Edit Captions to add the tag.

Takes a little getting used to, but it's not too bad. It has some quirks (glitchy keyboard focus, etc.), but they're Gradio and AUTO111 problems, not this extension's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants