This repository has been archived by the owner on Jul 3, 2019. It is now read-only.
Import new CustomCops/RefuteNot cop from rails/rails
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR imports rails/rails#32441. IMO, I think that it would be more plausible to write `require: rubocop-rails` instead of `require: custom_cops` in config/rails.yml, but first of all this PR writes `require: custom_cops` according to upstream.
koic
force-pushed
the
backport_new_custom_cops_refute_not_test_cop
branch
from
cc14f5b
to
e86cb2c
Compare
koic
changed the title
CustomCops/RefuteNotTest cop from rails/railsCustomCops/RefuteNotTest cop from rails/rails
|
Hmm, I'm not big fun of the decision of using Thanks for sending PR! (As always!!) |
|
v1.3.0 has been published. |
composerinteralia
added a commit
to composerinteralia/rails
that referenced
this pull request
Apr 19, 2018
We added `assert_not` in f75addd "to replace warty 'assert !foo'". fa8d35b agrees that it is warty, and so do I. This custom Rubocop rule turns the wart into a violation. As with my last custom cop, rails#32441, I want to make sure this looks right on code climate before pushing another commit to autocorrect everything. @toshimaru I just noticed toshimaru/rubocop-rails#26 Is there a better way to add these custom cops, or were you saying we shouldn't have custom cops at all?
koic
changed the title
CustomCops/RefuteNotTest cop from rails/railsCustomCops/RefuteNot cop from rails/rails
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR imports rails/rails#32441.
IMO, I think that it would be more plausible to write
require: rubocop-railsinstead ofrequire: custom_copsin config/rails.yml, but first of all this PR writesrequire: custom_copsaccording to upstream.