Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify ambiguous SemVer #334

Merged
merged 4 commits into from
Sep 25, 2023
Merged

fix: modify ambiguous SemVer #334

merged 4 commits into from
Sep 25, 2023

Conversation

Ryan-Dia
Copy link
Contributor

@Ryan-Dia Ryan-Dia commented Aug 30, 2023

Overview

Changes

  • react/framer-motion
  • react/emotion-utils
  • react/react-query

It means the same thing.

"react": ">=16.8.0 || ^17.0.0 || ^18" === "react": ">=16.8.0"

What version were you intending to use?

  • "react": ">=16.8.0" ?
  • "react": "^16.8.0 || ^17.0.0 || ^18" ?

Considering the presence of the || symbols after >=16.8.0, it seems that the intended version was "^16.8.0 || ^17.0.0 || ^18". I have modified the semver to "react": "^16.8.0 || ^17.0.0 || ^18".
If the intention was to specify >=16.8.0, I will modify it to "react": ">=16.8.0".


When using >= in conjunction with ||, it is typically used as follows: link

"engines": {
    "node": "^14.17.0 || ^16.13.0 || >=18.0.0"
  },

πŸ“Œ react-query

v1 peerDependencies

"peerDependencies": {
    "react": "^16.8.0"
  },

v2 peerDependencies

"peerDependencies": {
    "react": "^16.8.0 || ^17.0.0"
  },

v3 peerDependencies

 "peerDependencies": {
    "react": "^16.8.0 || ^17.0.0 || ^18.0.0"
  },

πŸ“Œ @emotion/react

v11.9.3

"peerDependencies": {
    "@babel/core": "^7.0.0",
    "react": ">=16.8.0"
}
    

πŸ“Œ framer-motion

The only unnecessary part was included in the peerDependencies.
At first, I set up peerDependencies correctly.
"However, unnecessary additions were made starting from v3.7
Starting from v7, the minimum React version requirement was updated to v18, and it was indicated correctly."

❗️v6

"peerDependencies": {
    "react": ">=16.8 || ^17.0.0 || ^18.0.0",
    "react-dom": ">=16.8 || ^17.0.0 || ^18.0.0"
}

βœ… v7

"peerDependencies": {
    "react": "^18.0.0",
    "react-dom": "^18.0.0"
}

PR Checklist

  • I read and included theses actions below
  1. I have read the Contributing Guide
  2. I have written documents and tests, if needed.

@netlify
Copy link

netlify bot commented Aug 30, 2023

βœ… Deploy Preview for slash-libraries ready!

Name Link
πŸ”¨ Latest commit 2892aa5
πŸ” Latest deploy log https://app.netlify.com/sites/slash-libraries/deploys/6510e0633aa35600087d289f
😎 Deploy Preview https://deploy-preview-334--slash-libraries.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@raon0211 raon0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching our typo, @Ryan-Dia !

@raon0211 raon0211 merged commit 258d09a into toss:main Sep 25, 2023
3 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants