fix(emotion-utils): refactor position function

[yoonminsang]

Overview

• improve type safe
• change wrong variable name

PR Checklist

• I read and included theses actions below

1. I have read the Contributing Guide
2. I have written documents and tests, if needed.

[netlify]

✅ Deploy Preview for slash-libraries ready!

Name	Link
🔨 Latest commit	57aadbd
🔍 Latest deploy log	https://app.netlify.com/sites/slash-libraries/deploys/63556c5123c4c20008203c72
😎 Deploy Preview	https://deploy-preview-83--slash-libraries.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[hoseungme]

These changes look just renaming. I think it's far from refactoring.
How about making the code more intuitive? (e.g. using IIFE to group related codes, or adding some comments to note what this code means, etc.)

[hoseungme]

Note my comment please. Thank you @yoonminsang !

[yoonminsang]

Thanks for comments @hoseungjang

• rename

I think renaming is refactoring.
I am studying refactoring with refactoring2 book(Martin Fowler). The book say naming is important. I attach my github link.
my github repo link

First I read this code, topOrCoordinates means top or Coordinates. But it means top or right or Coordinates. So I think this naming is wrong. If topOrRightOrCoordinates is so long, I rewrite something.

• IIFE

I think Nested Ternaries is poor readability. But it taste difference. I attach links.
nested-ternaries-are-great
nested-ternaries-are-bad

If you agree with nested ternaries are great, I will pull request this code.

  const [top, right, bottom, left] = (() => {
    if (!isPositionValue(positionOrTop)) {
      return [positionOrTop, topOrRightOrCoordinates as CSSPixelValue, ...values];
    }
    if (!isCSSPixelValue(topOrRightOrCoordinates)) {
      return [
        topOrRightOrCoordinates.top,
        topOrRightOrCoordinates.right,
        topOrRightOrCoordinates.bottom,
        topOrRightOrCoordinates.left,
      ];
    }
    return [topOrRightOrCoordinates, ...values];
  })();

• Other commits
  I write 3 commits. You comment only one commit. Other commits is ok?

If you want a new pull request, I will pull request. Thank you.

[hoseungme]

I think renaming is refactoring.
I am studying refactoring with refactoring2 book(Martin Fowler). The book say naming is important. I attach my github link.

@yoonminsang Yes, you are absolutely right. Sometimes renaming would be main point to make a readable code.

But, in the case of this position function, I think just renaming topOrCoordinates to topOrRightOrCoordinates have no impact to make it more readable.

But your IIFE example is what I want. It would be more readable than those complex ternaries. Please apply it and reopen this PR. Thanks.