chore: Add nvm configuration #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for slash-libraries ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
manudeli
changed the title
hoseungme
changed the title
hoseungme
suggested changes
Oct 26, 2022
.nvmrc
Outdated
| @@ -0,0 +1 @@ | |||
| 16.17 | |||
There was a problem hiding this comment.
(Minor)Add new line please.
raon0211
reviewed
Oct 26, 2022
raon0211
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.nvmrc for nvm user using deeper shell integration
Many JavaScript developers may use nvm to change node.js version rapidly.
Not perfectly, but It'll partially prevent contributors can use too old node.js version
In my case, nvm default node version is 14. but If this project have .nvmrc in root, my zsh-hook will change my node.js version to 16.17 automatically by using deeper shell integration.
Shopify/quilt, tanstack/query are using .nvmrc too. I think it's partially good way to prevent chance to make mistake. and I want to suggest to @toss/slash
@toss/slash might scope at node.js version 16.17 currently. So I added 16.17 into .nvmrc
PR Checklist