fix typecode decoding DoS

totaam · Aug 5, 2021 · f6254ab · f6254ab
1 parent f166033
commit f6254ab
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/rencode/_rencode.pyx b/rencode/_rencode.pyx
@@ -538,6 +538,8 @@ cdef decode(char *data, unsigned int *pos, long long data_length):
         return decode_fixed_dict(data, pos, data_length)
     elif typecode == CHR_DICT:
         return decode_dict(data, pos, data_length)
+    else:
+        raise Exception("invalid typecode %i" % typecode)
 
 def loads(data):
     """

diff --git a/tests/test_rencode.py b/tests/test_rencode.py
@@ -212,5 +212,14 @@ def test_version_exposed(self):
         assert rencode_orig.__version__
         self.assertEqual(rencode.__version__[1:], rencode_orig.__version__[1:], "version number does not match")
 
+    def test_invalidtypecode(self):
+        s = b';\x2f\x7f'
+        try:
+            rencode.loads(s)
+        except Exception:
+            pass
+        else:
+            raise Exception("invalid typecode should raise an Exception")
+
 if __name__ == '__main__':
     unittest.main()