Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java 9 compatibility #5

Merged
merged 3 commits into from Oct 19, 2017
Merged

Java 9 compatibility #5

merged 3 commits into from Oct 19, 2017

Conversation

alumi
Copy link
Contributor

@alumi alumi commented Oct 18, 2017

clj-http-lite uses javax.xml.bind.DatatypeConverter which is deprecated for removal since java 9.

This PR replaces clj-http-lite with clj-http to avoid ClassNotFoundException.

Thank you in advance.

totakke
totakke approved these changes Oct 19, 2017
View reviewed changes
Copy link
Owner

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, clj-http-lite seems inactive, so clj-http is a better choice.

@totakke totakke merged commit cd808a0 into totakke:master Oct 19, 2017
@totakke
Copy link
Owner

totakke commented Oct 19, 2017

Thanks.

@alumi alumi deleted the feature/java9 branch October 19, 2017 04:31
@alumi
Copy link
Contributor Author

alumi commented Oct 19, 2017

Thank you for merging! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@totakke totakke totakke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alumi @totakke