Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add es locale #1478

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Add es locale #1478

merged 2 commits into from
Apr 10, 2024

Conversation

diegort
Copy link
Contributor

@diegort diegort commented Apr 9, 2024

Proposed Change

Add Spanish translations

Related issues

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @diegort - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@marksie1988 marksie1988 changed the base branch from master to beta April 10, 2024 08:00
@marksie1988 marksie1988 merged commit de77098 into totaldebug:beta Apr 10, 2024
3 checks passed
Copy link

🎉 This PR is included in version 9.8.0-beta.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@diegort
Copy link
Contributor Author

diegort commented Apr 10, 2024 via email

@diegort
Copy link
Contributor Author

diegort commented Apr 10, 2024

It works properly, and now texts are shown in Spanish.

Copy link

🎉 This PR is included in version 10.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants