-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
427 Replace Moment.js with DayJS #430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marksie1988
added
type/feature
New feature or request
flag/breaking changes
A Change that will break current functionality
labels
May 21, 2021
This change will show the summary for the current day by default in calendar mode re #354
marksie1988
changed the title
427 Replace Moment.js with Luxon
427 Replace Moment.js with DayJS
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
flag/breaking changes
A Change that will break current functionality
type/feature
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the older Moment.js with the newer DayJS module.
fireEvent
which was causing build errorsRelated issues
closes #427 - Replace Moment with DayJS
closes #354 - Show summary for current day by default
Motivation and Context
How has this been tested
Tests have been completed on my lab, however I cannot count for all scenario's so it is possible some bugs still exist as this is a major change to the codebase. Due to this, this release will be a major upgrade.
Types of changes
Checklist