Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

427 Replace Moment.js with DayJS #430

Merged
merged 14 commits into from
May 27, 2021
Merged

Conversation

marksie1988
Copy link
Collaborator

@marksie1988 marksie1988 commented May 21, 2021

Description

This change replaces the older Moment.js with the newer DayJS module.

  • Improves loading speeds
  • Size reduced from 401KB to 154KB (61.60% reduction)
  • Fixes fireEvent which was causing build errors
  • Added warning if entities are not found
  • Adds default icon if one is not specified for calendar mode
  • fixes bug where using same icon with different colour on multiple calendars would show only one icon

Related issues

closes #427 - Replace Moment with DayJS
closes #354 - Show summary for current day by default

Motivation and Context

  • Performance improvements
  • Move to a supported datetime module
  • Reduction in size of the card

How has this been tested

Tests have been completed on my lab, however I cannot count for all scenario's so it is possible some bugs still exist as this is a major change to the codebase. Due to this, this release will be a major upgrade.

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988 marksie1988 added type/feature New feature or request flag/breaking changes A Change that will break current functionality labels May 21, 2021
@marksie1988 marksie1988 self-assigned this May 27, 2021
@marksie1988 marksie1988 marked this pull request as ready for review May 27, 2021 08:47
@marksie1988 marksie1988 merged commit 4ad3b56 into master May 27, 2021
@marksie1988 marksie1988 changed the title 427 Replace Moment.js with Luxon 427 Replace Moment.js with DayJS May 27, 2021
@marksie1988 marksie1988 deleted the 427-replace_moment_js_with_luxon branch October 18, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag/breaking changes A Change that will break current functionality type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Moment.JS with Luxon select current day by default in calendar mode
1 participant