Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): show "No Events" on empty days #433

Conversation

marksie1988
Copy link
Collaborator

Description

This change adds a new option showNoEventDays this allows a user to show text when there are no events on any days, this also changes the noEventsForTodayText option to noEventText to allow for more generic text when using this option.

PLEASE NOTE THIS IS A BREAKING CHANGE DUE TO THE OPTIONS CHANGING

Related issues

Motivation and Context

This feature has been requested and asked for a few times, If someone wants to show empty days so that they dont go to appointments assuming they are today, this will aim to stop that from happening.

How has this been tested

This has been tested in my lab and appears to be working as expected.

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

BREAKING CHANGE: option `noEventsForTodayText` changed to `noEventText`

closes #221
@marksie1988 marksie1988 added type/feature New feature or request flag/breaking changes A Change that will break current functionality labels Jun 1, 2021
@marksie1988 marksie1988 self-assigned this Jun 1, 2021
@marksie1988 marksie1988 merged commit 9a9bcf9 into master Jun 1, 2021
@marksie1988 marksie1988 deleted the 221-show_next_x_number_of_days_vs_showing_the_next_x_number_of_days_with_events branch June 1, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag/breaking changes A Change that will break current functionality type/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show next X number of days vs. Showing the next X number of days with events.
1 participant