Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calendar month change icons not showing in 2021.11 beta #521

Merged
merged 3 commits into from
Oct 28, 2021

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Oct 28, 2021

Breaking changes made recently to the frontend, specifically in the ha-icon-button element, causes some buttons to not show up. This PR fixes that issue while maintaining backward compatibility.
You can see the breaking changes here:

https://github.com/home-assistant/frontend/blob/master/src/components/ha-icon-button.ts#L10-L11

home-assistant/frontend@0c940be#diff-b7749fac30d4d29a769a04d77d9e72093cfdfecd6e325fba66649575229bde9c

i.e I'm using the latest beta version of HA that was released a couple of hours ago

How has this been tested

Ran on my local hass

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@regevbr
Copy link
Contributor Author

regevbr commented Oct 28, 2021

@totaldebug can you please CR?

@marksie1988 marksie1988 added the type/bug Something isn't working label Oct 28, 2021
Copy link
Collaborator

@marksie1988 marksie1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, please update the version in the pyproject.toml and rebuild npm run build

you may need to merge the upstream changes first as I have recently done another release

@regevbr
Copy link
Contributor Author

regevbr commented Oct 28, 2021

Code looks good, please update the version in the pyproject.toml and rebuild npm run build

you may need to merge the upstream changes first as I have recently done another release

Thanks, I rebased and changed the version in package.json (not pyproject.toml as you, I guess, mentioned by mistake) and then ran the build (so version 5.2.2 is now bundled). Please let me know if there is anything else

@marksie1988
Copy link
Collaborator

yes sorry! jumping between js and python...

@marksie1988 marksie1988 merged commit e79dbac into totaldebug:master Oct 28, 2021
@marksie1988 marksie1988 changed the title fix icons not showing in new frontend version fix calendar month change icons not showing in 2021.11 beta Oct 28, 2021
@regevbr
Copy link
Contributor Author

regevbr commented Oct 28, 2021

yes sorry! jumping between js and python...

haha no worries, thanks for the swift CR :-)

@marksie1988 marksie1988 changed the title fix calendar month change icons not showing in 2021.11 beta fix: calendar month change icons not showing in 2021.11 beta Oct 28, 2021
@regevbr regevbr deleted the icons branch October 28, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants