Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Delete moviefile not movie #87

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Conversation

muqshots
Copy link
Contributor

@muqshots muqshots commented Oct 11, 2021

Description

The del_movie_file function was deleting the movie not the moviefile

Related issues

Motivation and Context

fix bug

How has this been tested

Types of changes

  • Docs change / refactoring.
  • Non-breaking change (fix or feature that wouldn't cause existing functionality to change/break).
  • Breaking change (fix or feature that would cause existing functionality to change/break).

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes don't generate new warnings.
  • I have read the CONTRIBUTING document.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests pass.

@marksie1988
Copy link
Collaborator

Hi @muqshots,

Thanks for the contribution, please could you update pyproject.toml with the new version 2.0.7 without this the build will fail.

@marksie1988 marksie1988 added the type/bug Something isn't working label Oct 28, 2021
@marksie1988 marksie1988 self-assigned this Oct 28, 2021
@Archmonger
Copy link
Contributor

@marksie1988 this PR seems mergeable to me.

@marksie1988 marksie1988 changed the title Delete moviefile not movie fix: Delete moviefile not movie Nov 5, 2021
@marksie1988 marksie1988 merged commit 2f30d6e into totaldebug:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants