-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding Lidarr API (Sourcery refactored) #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @sourcery-ai[bot], thank you for submitting a PR! We will respond as soon as possible.
aa80a35
to
d767904
Compare
Sourcery Code Quality Report✅ Merging this PR will increase code quality in the affected files by 0.01%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
_path = "" if not id_ else f"/{id_}" | ||
_path = f"/{id_}" if id_ else "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function LidarrAPI.get_metadata_profile
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
)
path = "indexer" if not id_ else f"indexer/{id_}" | ||
path = f"indexer/{id_}" if id_ else "indexer" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function RadarrAPI.get_indexer
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
)
path = "metadataprofile" if not id_ else f"metadataprofile/{id_}" | ||
path = f"metadataprofile/{id_}" if id_ else "metadataprofile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function ReadarrAPI.get_metadata_profile
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
)
path = "delayprofile" if not id_ else f"delayprofile/{id_}" | ||
path = f"delayprofile/{id_}" if id_ else "delayprofile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function ReadarrAPI.get_delay_profile
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
)
path = "releaseprofile" if not id_ else f"releaseprofile/{id_}" | ||
path = f"releaseprofile/{id_}" if id_ else "releaseprofile" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function ReadarrAPI.get_release_profile
refactored with the following changes:
- Swap if/else branches of if expression to remove negation (
swap-if-expression
)
Pull Request #97 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
81-add_lidarr_support
branch, then run:Help us improve this pull request!