Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Total.js j-Input dircustom configuration broken. #43

Closed
DPain opened this issue Jul 23, 2019 · 1 comment
Closed

Total.js j-Input dircustom configuration broken. #43

DPain opened this issue Jul 23, 2019 · 1 comment

Comments

@DPain
Copy link
Contributor

DPain commented Jul 23, 2019 •
edited
Loading

Hi, I noticed that the dircustom config for j-Input wasn't working on Total.js Flow and I figured out that the j-Input javascript file was out-of-date and prevented the dircustom configuration from working.

Whenever clicking the plus button to add a custom value, the j-Directory would return the correct value via the call back function, but the j-Input textbox would not correctly display it.

The latest version of j-Input seems to have fixed this bug, so assuming that this was not intended, I updated the j-Input code for Total.js Flow.

The following commit on my fork fixes this issue.
DPain@7bc485c
@petersirka
Copy link
Collaborator

Great and thank you. Please create a pull request.

@DPain DPain mentioned this issue Jul 24, 2019
Merged
@DPain DPain closed this as completed Jul 24, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petersirka @DPain