Change string formatting

[psolyca]

Strings formatting changes :

• Fix TypeError in LandXML issue [BUG]potential type error #146
• Concat strings ("" + "") to F-Strings
• Old style (%) to F-Strings
• Formatted strings (.format()) to F-Strings
• Specific case of scanwin32.py
• specific case of gettext strings

[steko]

See https://github.com/ikamensh/flynt

[psolyca]

I have tried with flynt but it did not catch all strings. Do not know why !
I have also tried pyupgrade but that is worse, nothing had changed ^^
So I already have all my strings changed except gettext strings but I am making another pass to check everything is ok.

[psolyca]

@steko So looking at gettext and translation, F-Strings can not be used as-is.
We should keep the old style % syntax or the .format() one.
For the last one, we have to change all %s in .po files to {}. I do not think if it is worth it.

If we want to stick to F-Strings, a workaround is here https://stackoverflow.com/a/56264202 and we can modify our _ function.

[steko]

You did a huge work!

The straightforward approach seems to use f-strings everywhere, except where gettext is needed, and use .format() with gettext.

Or we could standardize on using .format() everywhere.

But most importantly we need to move away from implicit conversion and formatting.

[psolyca]

I thought of using .format() everywhere but it is claimed to be slower than F-Strings.
And % is faster than .format() : https://stackoverflow.com/questions/40714555/python-string-formatting-is-more-efficient-than-format-function
So maybe we can keep % for little string formatting as gettext could be.

[steko]

You did a huge work!

The straightforward approach seems to use f-strings everywhere, except where gettext is needed, and use .format() with gettext.

Or we could standardize on using .format() everywhere.

But most importantly we need to move away from implicit type conversion and formatting, adopting a consistent code style.

[steko]

On a second thought, perhaps the easiest solution is to use f-strings in the totalopenstation package, and %-formatting in the scripts directory. We don't need gettext in the package, only in the command line and GUI scripts.

[psolyca]

So I revert scripts files ?
Not a huge fan :p

[steko]

@psolyca what do you think about the documentation I added? I thought it was important to document what we had decided and you implemented in this PR.

[psolyca]

Yes, good for me. I was surprised by the "user-facing" term as I am more used to front-end but it is a legit term.

I let you review this PR, I won't do it, it is not fair :p

[psolyca]

Ok good to go.
When you do not read everything, you are one step behind ^^;