Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add topcon model connector #150

Merged
merged 6 commits into from
Sep 18, 2021
Merged

add topcon model connector #150

merged 6 commits into from
Sep 18, 2021

Conversation

enzococca
Copy link
Contributor

No description provided.

Copy link
Collaborator

@steko steko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes are needed.

totalopenstation/models/topcon.py Outdated Show resolved Hide resolved
totalopenstation/models/topcon.py Outdated Show resolved Hide resolved
totalopenstation/models/__init__.py Outdated Show resolved Hide resolved
#! /usr/bin/env python
# -*- coding: utf-8 -*-
# filename: topcon gpt 3005.py
# Copyright 2008 Enzo Cocca <enzo.ccc@gmail.com>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's 2021 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@steko
Copy link
Collaborator

steko commented Sep 17, 2021

All looks good now, I don't understand why one of the travis checks is not working. Any idea @psolyca ?

@steko steko merged commit 3e07112 into totalopenstation:main Sep 18, 2021
@psolyca
Copy link
Collaborator

psolyca commented Sep 18, 2021

All looks good now, I don't understand why one of the travis checks is not working. Any idea @psolyca ?

@steko No idea, I have seen the message but did not had time to check why.

@steko
Copy link
Collaborator

steko commented Sep 18, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants