New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #157: binary data from download need to be saved as binary #163

Merged

steko merged 2 commits into main from 157-binary-output-cli

Dec 10, 2021

Collaborator

steko commented Oct 24, 2021 •

edited

Fixes #157


          fix: binary data from download need to be saved as binary

44277a6

steko added this to the v0.6 milestone

steko requested review from enzococca and psolyca

October 24, 2021 14:47

Collaborator Author

steko commented Oct 24, 2021 •

edited

Fixes #157

Collaborator Author

steko commented Dec 9, 2021

Hey @enzococca @psolyca do you have any feedback on this PR?

If you could confirm that it works as expected, I can merge it.

Contributor

enzococca commented Dec 10, 2021 via email

Hi Stefano, for me you can merge E Il gio 9 dic 2021, 23:37 Stefano Costa ***@***.***> ha scritto:

Hey @enzococca <https://github.com/enzococca> @psolyca <https://github.com/psolyca> do you have any feedback on this PR? If you could confirm that it works as expected, I can merge it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2P5KCKJXHNULZONI5MPWDUQEVT3ANCNFSM5GTRBPMQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

psolyca approved these changes

View reviewed changes

Collaborator

psolyca commented Dec 10, 2021

Hoo sorry forgot this.


          Merge branch 'main' into 157-binary-output-cli

9c96703

Collaborator Author

steko commented Dec 10, 2021

Hi Stefano, for me you can merge

E

Thank you @enzococca, if you want you can approve the pull request directly on GitHub.

steko merged commit bb17ab2 into main

steko deleted the 157-binary-output-cli branch

December 10, 2021 20:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment