Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #155: remove broken import #172

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

steko
Copy link
Collaborator

@steko steko commented Oct 2, 2023

This is a very brutal fix for #155 that follows @lbartoletti first pull request #166 but also removes the "impossible" try..except clause where the KeyboardInterrupt would be raised.

@steko steko linked an issue Oct 2, 2023 that may be closed by this pull request
@steko steko requested a review from lbartoletti October 2, 2023 21:04
@steko steko added this to the v0.6 milestone Oct 3, 2023
Copy link
Collaborator

@psolyca psolyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @lbartoletti has done it and it works, I cna onyl approve ^^;

@steko
Copy link
Collaborator Author

steko commented Oct 3, 2023

Just to clarify: the serial download code in models/__init__.py is only used by totalopenstation-cli-connector. The GUI has a separate built-in function for serial download (almost identical). There is room for improvement, but it would be better if this was documented in the code.

@lbartoletti
Copy link
Contributor

I can try this week, but AFAIRember seems ok for me.

@steko steko merged commit c8822cd into main Oct 16, 2023
16 checks passed
@steko steko deleted the 155-bug-threadingexceptions-does-not-exist branch April 30, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] threading.exceptions does not exist
3 participants