Fix broken delete

totem · Apr 1, 2016 · 01940a5 · 01940a5
1 parent 79bd10a
commit 01940a5
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 5 deletions.
diff --git a/deployer/tasks/deployment.py b/deployer/tasks/deployment.py
@@ -72,7 +72,12 @@ def create_search_parameters(deployment, defaults=None):
     """
 
     deployment = dict_merge(deployment or {}, defaults or {}, {
-        'meta-info': {}
+        'meta-info': {},
+        'deployment': {
+            'name': '',
+            'version': ''
+        },
+        'id': ''
     })
     return {
         'meta-info': dict_merge(
@@ -235,8 +240,7 @@ def delete(name, version=None):
     search_params = create_search_parameters({
         'deployment': {
             'name': name,
-            'version': version or 'all',
-            'id': ''
+            'version': version or 'all'
         }
     })
     return _using_lock.si(

diff --git a/tests/unit/tasks/test_deployment.py b/tests/unit/tasks/test_deployment.py
@@ -8,7 +8,7 @@
 from paramiko import SSHException
 
 from conf.appconfig import DEPLOYMENT_MODE_BLUEGREEN, \
-    DEPLOYMENT_MODE_REDGREEN, DEPLOYMENT_STATE_STARTED
+    DEPLOYMENT_MODE_REDGREEN, DEPLOYMENT_STATE_STARTED, CLUSTER_NAME
 from deployer.celery import app
 from deployer.tasks.exceptions import NodeNotUndeployed, MinNodesNotRunning, \
     NodeCheckFailed, MinNodesNotDiscovered, MaxStartConcurrencyReached
@@ -17,7 +17,7 @@
 
 from deployer.tasks.deployment import _pre_create_undeploy, \
     _wait_for_undeploy, _fleet_check_deploy, _check_node, _check_deployment, \
-    _check_discover, _start_deployment
+    _check_discover, _start_deployment, create_search_parameters
 
 __author__ = 'sukrit'
 
@@ -484,3 +484,29 @@ def side_effect(**kwargs):
     # Then: Deployment state gets updated as expected
     m_store.update_state.assert_called_once_with(MOCK_DEPLOYMENT_ID,
                                                  DEPLOYMENT_STATE_STARTED)
+
+
+def test_create_search_parameters():
+    # Given: Minimal deployment for which search parameters needs to be created
+    dep = {
+        'deployment': {
+            'name': 'dummy-deployment'
+        }
+    }
+
+    # When: I create search parameters for the given deployment
+    search_params = create_search_parameters(dep)
+
+    # Then: Expected Search parameters are returned
+    dict_compare(search_params, {
+        'deployment': {
+            'name': 'dummy-deployment',
+            'version': '',
+            'id': ''
+        },
+        'meta-info': {
+            'deployer': {
+                'cluster': CLUSTER_NAME
+            }
+        }
+    })