Feature coalescing support #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold off on review until tests have been made. |
… that hadn't ended yet. Added test for coalescing.
|
Added integration test. |
| @@ -14,14 +14,13 @@ module.exports = Datastore; | |||
| */ | |||
| function Datastore() { | |||
| // TODO: Switch this to something that can manage the size, evict old, etc. LRU maybe? | |||
| this.cache = {}; | |||
| this.cache = []; | |||
There was a problem hiding this comment.
Clarification: Any reason this needs to be an array instead of object ?
There was a problem hiding this comment.
Oops. That was never reverted back. It should be an object.
|
@FunnyGopher Looks like there are some conflicts (possibly due to other branch that got merged with develop). Could you merge develop onto this branch and resolve conflicts ? |
|
Thanks for pointing that out. I need to go back and revert some of the code. |
| * @returns [] of jobs | ||
| */ | ||
| Factory.prototype.getJobs = function getJobs() { | ||
| var datastore = this.jobs.get(); |
There was a problem hiding this comment.
Suggestion: Possibly use https://lodash.com/docs#values
kylehuntsman
force-pushed
the
feature_coalescing-support
branch
from
b196027
to
abf02be
Compare
kylehuntsman
force-pushed
the
feature_coalescing-support
branch
from
abf02be
to
173ac68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added coalescing support to save resources. Coalescing time window can be configured in the config in the "coalescingPeriod" property. Duplicate requests that are fired while a job is building will be thrown away and redirected to the running job. Duplicate requests that are fired during the coalescing period will also be thrown away and redirected to the original job.