Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for slack notifications #34

Merged
merged 1 commit into from Aug 22, 2016
Merged

Bugfix for slack notifications #34

merged 1 commit into from Aug 22, 2016

Conversation

kylehuntsman
Copy link
Contributor

@kylehuntsman kylehuntsman commented Aug 4, 2016 •
edited

Overview

The channel property in templates/slack.json was being referenced incorrectly. It should have been notification.channel. Because the channel was then an empty string, it defaulted back to the channel given by the integration url.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.969% when pulling 1152374 on bugfix_slack-channels into dd38517 on develop.

@sukrit007 sukrit007 merged commit 6dd3534 into develop Aug 22, 2016
@sukrit007 sukrit007 deleted the bugfix_slack-channels branch August 22, 2016 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylehuntsman @coveralls @sukrit007