add setDateTime parameter for DriverJdbcType[DateTime]

[xuwei-k]

I think #30 is NOT right way in most cases.
But I have not change the default behavior directly for keep compatibility.

[tototoshi]

I still don't understand why the current implementation is not correct.

Can you please explain the correct behavior you expect? Or I would like some test code. Also, can you tell me which database you are using?

[y-yu]

I agree with @xuwei-k, there is something wrong in the current implementation. I wrote this test to show up: 👀

• master...y-yu:slick-joda-mapper:xuwei-k-setDateTime-with-test

[info] MySQLJodaSupportSpec:
[info] JodaSupport
[info] - should enable us to use joda-time with slick
[info] - should enable us to use joda-time with string interpolation API
[info] - can be used with comparative operators
[info] - should be able to filter with the specified date
[info] - should be the same in/out joda-time zoned Asia/Tokyo
[info] - should be the same in/out joda-time zoned UTC *** FAILED ***
[info]   1354806000000 was not equal to 1354838400000 (JodaSupportSpec.scala:252)
[info] - should be the same in/out joda-time zoned Europe/London *** FAILED ***
[info]   1354806000000 was not equal to 1354838400000 (JodaSupportSpec.scala:252)
[info] - should be the same in/out joda-time zoned America/New_York *** FAILED ***
[info]   1354806000000 was not equal to 1354856400000 (JodaSupportSpec.scala:252)

This test is comparison of UTC zoned joda DateTime value then save into the table, and that loaded from DB. In SQL TIMESTAMP doesn't hold timezone but unix epoch times of those must be the same. So I think the current way is not correct. So I think it would be better to revert #30 or merge this PR. @xuwei-k san's fix version pass the test.

[info] MySQLJodaSupportWithoutCalenderSpec:
[info] JodaSupport
[info] - should enable us to use joda-time with slick
[info] - should enable us to use joda-time with string interpolation API
[info] - can be used with comparative operators
[info] - should be able to filter with the specified date
[info] - should be the same in/out joda-time zoned Asia/Tokyo
[info] - should be the same in/out joda-time zoned UTC
[info] - should be the same in/out joda-time zoned Europe/London
[info] - should be the same in/out joda-time zoned America/New_York

getValue also should be fixed in addition to @xuwei-k san's fix.
xuwei-k/slick-joda-mapper@setDateTime...y-yu:slick-joda-mapper:setDateTime-and-getDateTime

I don't understand why ResultSet#getTimestamp takes Calendar but it works.

[y-yu]

Are there any updates? 👀

[y-yu]

@tototoshi 👀 🙏

[tototoshi]

I had the opportunity to speak with @y-yu directly about this issue some time ago. I really want to solve this problem fundamentally. But if it causes incompatible changes, users may have a new accident.

This library is already not actively developed. And there will be no need for it. A major upgrade to fundamentally solve the problem is overkill. This PR is a workaround, but at least it is safe for current users.

[y-yu]

Thank you!